joseluisll commented on PR #8892: URL: https://github.com/apache/hadoop/pull/8892#issuecomment-6656809855
Thanks for the review, @pan3793. Both nits are addressed: 1. The two comments now say it once, at the `jetty-util` declaration: `hadoop-client-runtime` does not shade `jetty-util`, so it is declared directly to keep it in this jar. The stale "not in client" placeholder above the hadoop-common block is gone. 2. The description now says that `jersey-container-jetty-http` and `jetty-continuation` are no longer in the minicluster jar, and that `jetty-util` stays at the same 377 relocated classes. On the earlier question about `<optional>true</optional>`: it is how this pom collects dependencies into the shaded jar, not an optional transitive dependency. The published pom carries no Jetty or Jersey dependencies in either direction. The branch is rebased on current trunk and Build and Yetus are re-running on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
