[
https://issues.apache.org/jira/browse/HADOOP-20004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139329#comment-18139329
]
ASF GitHub Bot commented on HADOOP-20004:
-----------------------------------------
hadoop-yetus commented on PR #8946:
URL: https://github.com/apache/hadoop/pull/8946#issuecomment-6675302106
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 22s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 2 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 4s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 47s | | trunk passed |
| +1 :green_heart: | compile | 10m 43s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 10m 9s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 1m 3s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 21s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 52s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 55s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 8s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 3s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 21s | | the patch passed |
| +1 :green_heart: | compile | 8m 57s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 8m 57s | | the patch passed |
| +1 :green_heart: | compile | 9m 42s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 9m 42s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 55s | | hadoop-common-project:
The patch generated 0 new + 125 unchanged - 1 fixed = 125 total (was 126) |
| +1 :green_heart: | mvnsite | 2m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 3s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 2m 4s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 36s | | the patch passed |
| +1 :green_heart: | shadedclient | 16m 48s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 8s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 19m 0s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 4s | | hadoop-kms in the patch passed.
|
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 157m 28s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8946/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8946 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 279ff678eb90 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 4f0ecce86ed3e9f1f9f9db3bad9ede10f2336e4b |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8946/1/testReport/ |
| Max. process+thread count | 1265 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms U:
hadoop-common-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8946/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Send a filter's refusal reason in the response body for every HTTP method
> -------------------------------------------------------------------------
>
> Key: HADOOP-20004
> URL: https://issues.apache.org/jira/browse/HADOOP-20004
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: common, hadoop-auth, kms, security
> Reporter: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> {{AuthenticationFilter}}, {{RestCsrfPreventionFilter}} and
> {{KMSAuthenticationFilter}} put their refusal message in the HTTP reason
> phrase. The CSRF and KMS filters do it by casting to
> {{org.eclipse.jetty.server.Response}} and calling {{setStatusWithReason}}.
> Jetty writes an error-page body only for GET, POST and HEAD, on 9.4 and on
> 12. So for a refused PUT or DELETE the phrase is the only place the message
> appears, and Jetty 12 does not send one.
> h3. Changes
> * New request attribute
> {{AuthenticationFilter.ERROR_MESSAGE_FOR_ANY_METHOD_ATTRIBUTE}} marks an
> error whose message the caller must be able to read.
> * {{HttpServer2}} installs an error handler that writes the error page for a
> marked error whatever the method. It extends {{ErrorPageErrorHandler}}, so
> web.xml {{<error-page>}} mappings keep working. Unmarked errors are handled
> exactly as today.
> * The three filters mark their refusals. In place of the Jetty cast they call
> the Servlet API's {{setStatus(int, String)}}, so Jetty 9.4 and any other
> container that sends a reason phrase still sends it. This also takes the
> Jetty dependency out of filters that downstream projects run in their own
> containers.
> h3. Compatibility
> The status code and the reason phrase are unchanged. A refused PUT or DELETE
> now also has an error-page body.
> h3. Tests
> {{TestRestCsrfPreventionFilter}} checks the phrase and the marker.
> {{TestHttpServer}} checks that a marked PUT error has a body and an unmarked
> one does not.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
