[
https://issues.apache.org/jira/browse/HADOOP-20005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139555#comment-18139555
]
ASF GitHub Bot commented on HADOOP-20005:
-----------------------------------------
hadoop-yetus commented on PR #8947:
URL: https://github.com/apache/hadoop/pull/8947#issuecomment-6682872053
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 4 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 56m 29s | | trunk passed |
| +1 :green_heart: | compile | 23m 8s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 21m 55s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 6m 11s | | trunk passed |
| +1 :green_heart: | mvnsite | 7m 8s | | trunk passed |
| +1 :green_heart: | javadoc | 5m 21s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 5m 31s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 15m 7s | | trunk passed |
| +1 :green_heart: | shadedclient | 38m 43s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 31s | | the patch passed |
| +1 :green_heart: | compile | 18m 32s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 18m 32s | | the patch passed |
| +1 :green_heart: | compile | 19m 9s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 19m 9s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 6m 2s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8947/1/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 1 new + 203 unchanged - 0 fixed = 204 total (was
203) |
| +1 :green_heart: | mvnsite | 6m 55s | | the patch passed |
| +1 :green_heart: | javadoc | 5m 25s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 6m 16s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 16m 22s | | the patch passed |
| +1 :green_heart: | shadedclient | 39m 46s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 3m 54s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 26m 6s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 36s | | hadoop-kms in the patch passed.
|
| +1 :green_heart: | unit | 3m 1s | | hadoop-hdfs-client in the patch
passed. |
| -1 :x: | unit | 291m 23s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8947/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 2m 35s | | The patch does not
generate ASF License warnings. |
| | | 639m 44s | | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdfs.server.balancer.TestBalancerRPCDelay |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8947/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8947 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 5477d6e0a93d 5.15.0-198-generic #208-Ubuntu SMP Fri Sep 4
10:22:38 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / a31029d5b3cd09aca0a369744d9cebc146b2544e |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8947/1/testReport/ |
| Max. process+thread count | 2250 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-auth
hadoop-common-project/hadoop-common hadoop-common-project/hadoop-kms
hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8947/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Write a refused fsimage transfer's reason into the response body
> ----------------------------------------------------------------
>
> Key: HADOOP-20005
> URL: https://issues.apache.org/jira/browse/HADOOP-20005
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: hdfs
> Reporter: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> When {{ImageServlet}} refuses a transfer, it reports why only in the reason
> phrase, set through a cast to Jetty's {{Response}}. The servlet closes its
> output stream on every request, which commits the response before the
> container can write an error page. On a container that sends no custom
> phrase, which is Jetty 12 (HADOOP-19972), the SecondaryNameNode or standby
> NameNode is left with a bare status code.
> h3. Changes
> * {{ImageServlet}} writes the reason into the body itself, so the reason no
> longer depends on how the container renders errors. It keeps the phrase
> through {{setStatus(int, String)}}, without the Jetty cast.
> * The three readers of a failed transfer read the body before falling back to
> the phrase: {{Util#doGetUrl}}, {{TransferFsImage}}'s upload, and
> {{EditLogFileInputStream}}. They use the reader added in HADOOP-20003.
> * A refusal that reaches the servlet's own catch block after the response is
> committed is logged at DEBUG rather than reported a second time.
> h3. Compatibility
> No change on Jetty 9.4. The reason is in both the phrase and the body.
> h3. Tests
> {{TestCheckpoint}} asserts the reason the client reports for a refused
> transfer.
> Depends on HADOOP-20003.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
