[
https://issues.apache.org/jira/browse/HADOOP-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139770#comment-18139770
]
ASF GitHub Bot commented on HADOOP-20013:
-----------------------------------------
joseluisll commented on PR #8891:
URL: https://github.com/apache/hadoop/pull/8891#issuecomment-6690757288
@pjfanning To be reviewed as well. Once the 20012 to the 20016 are merged,
we have completed the preparations and we could make the first step of the
Jetty9 migration, the HADOOP-19970 (jetty-phase-a => Fix the javax servlet API
to 4.0.1 and jetty9.version to 9.4.58 across the codebase)
> HADOOP - Remove the duplicate javax.annotation-api from the classpath
> ---------------------------------------------------------------------
>
> Key: HADOOP-20013
> URL: https://issues.apache.org/jira/browse/HADOOP-20013
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, common
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Scope*:
> * hadoop-project/pom.xml: on javax-websocket-server-impl, exclude
> javax.annotation:javax.annotation-api, which arrives through
> jetty-annotations. jakarta.annotation-api 1.3.5 already provides the same
> javax.annotation classes.
> * LICENSE-binary and NOTICE-binary: replace
> javax.annotation:javax.annotation-api:1.3.2 with
> jakarta.annotation:jakarta.annotation-api:1.3.5. The jakarta jar is already
> bundled (through jersey-common) but is missing from LICENSE-binary.
> * hadoop-yarn-server-nodemanager: add TestAnnotationApiClasspath, which
> checks that javax/annotation/PostConstruct.class comes from exactly one jar,
> jakarta.annotation-api. With trunk's poms it fails: both jars provide the
> class. It is self-contained and does not depend on HADOOP-19970.
> *Why*: two jars publish the javax.annotation packages, and which one a module
> sees depends on jar order.
> *Impact on Jetty 9*: none. Same classes.
> *Downstream*:
> * hadoop-yarn-server-nodemanager, the only module that declares
> javax-websocket-server-impl: its consumers no longer get javax.annotation-api
> 1.3.2. jakarta.annotation-api 1.3.5 provides the same javax.annotation
> classes.
> * hadoop-client-minicluster: loses its relocated copy of javax.annotation-api
> and keeps the relocated jakarta.annotation-api. Not API.
> * hadoop-client-api, hadoop-client-runtime: unchanged.
> *CI*: touches hadoop-project, so a full build.
> *PR*: https://github.com/apache/hadoop/pull/8891
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
