[
https://issues.apache.org/jira/browse/HADOOP-20013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139814#comment-18139814
]
ASF GitHub Bot commented on HADOOP-20013:
-----------------------------------------
pjfanning commented on code in PR #8891:
URL: https://github.com/apache/hadoop/pull/8891#discussion_r4496372592
##########
NOTICE-binary:
##########
@@ -456,6 +456,9 @@ The following artifacts are EPL and ASL2.
The following artifacts are EPL and CDDL 1.0.
* org.eclipse.jetty.orbit:javax.mail.glassfish
+The following artifacts are EPL 2.0 and GPLv2 with classpath exception.
Review Comment:
This says EPL 2.0 and GPLv2 with classpath exception, but `LICENSE-binary`
lists `jakarta.annotation-api` under EPL 2.0 only. Could the two files be made
consistent? No other `jakarta.*` artifact has a stanza in `NOTICE-binary`, so
dropping this one may be the simplest fix. Otherwise `LICENSE-binary` should
mention the GPLv2 CE option too.
##########
LICENSE-binary:
##########
@@ -625,7 +625,6 @@ CDDL 1.1 + GPLv2 with classpath exception
-----------------------------------------
com.sun.xml.bind:jaxb-impl:2.2.3-1
-javax.annotation:javax.annotation-api:1.3.2
Review Comment:
Could you check `hadoop-gcp` before this entry goes?
`google-cloud-storage:2.52.0` has a compile-scope dependency on
`javax.annotation-api:1.3.2`, and the shade `artifactSet` in `hadoop-gcp` does
not include `javax.annotation`, so those classes are not bundled in the shaded
jar.
I have not built this, so can you run a dist with `-Dhadoop-gcp-package` and
confirm two things?
1. Whether `javax.annotation-api-1.3.2.jar` still ends up in the dist. If it
does, it still needs this licence entry.
2. Whether `hadoop-gcp` still has everything it needs at runtime. If the jar
is not shipped, the `javax.annotation` classes have to come from somewhere else
on its classpath.
> HADOOP - Remove the duplicate javax.annotation-api from the classpath
> ---------------------------------------------------------------------
>
> Key: HADOOP-20013
> URL: https://issues.apache.org/jira/browse/HADOOP-20013
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, common
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Scope*:
> * hadoop-project/pom.xml: on javax-websocket-server-impl, exclude
> javax.annotation:javax.annotation-api, which arrives through
> jetty-annotations. jakarta.annotation-api 1.3.5 already provides the same
> javax.annotation classes.
> * LICENSE-binary and NOTICE-binary: replace
> javax.annotation:javax.annotation-api:1.3.2 with
> jakarta.annotation:jakarta.annotation-api:1.3.5. The jakarta jar is already
> bundled (through jersey-common) but is missing from LICENSE-binary.
> * hadoop-yarn-server-nodemanager: add TestAnnotationApiClasspath, which
> checks that javax/annotation/PostConstruct.class comes from exactly one jar,
> jakarta.annotation-api. With trunk's poms it fails: both jars provide the
> class. It is self-contained and does not depend on HADOOP-19970.
> *Why*: two jars publish the javax.annotation packages, and which one a module
> sees depends on jar order.
> *Impact on Jetty 9*: none. Same classes.
> *Downstream*:
> * hadoop-yarn-server-nodemanager, the only module that declares
> javax-websocket-server-impl: its consumers no longer get javax.annotation-api
> 1.3.2. jakarta.annotation-api 1.3.5 provides the same javax.annotation
> classes.
> * hadoop-client-minicluster: loses its relocated copy of javax.annotation-api
> and keeps the relocated jakarta.annotation-api. Not API.
> * hadoop-client-api, hadoop-client-runtime: unchanged.
> *CI*: touches hadoop-project, so a full build.
> *PR*: https://github.com/apache/hadoop/pull/8891
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
