joseluisll commented on PR #8841:
URL: https://github.com/apache/hadoop/pull/8841#issuecomment-6927689728

   Thanks for the daemon comparison — that settles it. The `about` root wrap 
was a 3.5.0-only artifact from HADOOP-19544 that only tests pinned, so the PR 
now drops the wrapped mapper entirely: `locateMapper` returns the one 
configured mapper for every type, and the two `about` hunks in 
`TimelineServer.md` are reverted to the top-level body. The two 
`TimelineAboutReader` test classes read the top-level object, 
`TestYarnJacksonJaxbJsonProvider` expects `{"About":"test"}`, and the release 
note on YARN-12030 and the description state that about responses return the 
fields at the top level instead of `{"about":{...}}`, as in 3.4. 
`/ws/v2/timeline/` gets the unwrapped body that `TimelineServiceV2.md` 
documents back as well.
   
   @pjfanning — note this changes the about shape from what you approved: with 
the wrap dropped, every response in pan3793's matrix now matches 3.4.3, and the 
one-mapper change also keeps your earlier point about never mutating a mapper 
in use.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to