joseluisll commented on PR #8841:
URL: https://github.com/apache/hadoop/pull/8841#issuecomment-6933120925

   Both points addressed, on head `aca3e0f71a9`.
   
   **ATSv2 about shape** — the PR description now calls the ATSv2 compatibility 
change out explicitly: because `TimelineReaderServer` and 
`NodeTimelineCollectorManager` register `YarnJacksonJaxbJsonProvider`, dropping 
the `TimelineAbout` wrap changes `GET /ws/v2/timeline/` from 
`{"about":{"About":...}}` in 3.5.0 to the top-level `{"About":...}` that 
`TimelineServiceV2.md` documents, and a client reading the `about` wrapper gets 
null fields. The YARN-12030 release note now lives in the Jira **Release Note 
field** (it was only a paragraph in the description before — the field itself 
was empty) and covers the ATSv2 change too.
   
   **Error bodies** — confirmed, and it was a real gap. 
`GenericExceptionHandler` returns `RemoteExceptionData` (`@XmlRootElement(name 
= "RemoteException")`): where Jettison wrote it, 404/400 bodies were 
`{"RemoteException":{...}}`; with Jackson only they are the flat 
`{"exception":...,"message":...,"javaClassName":...}`. Two mitigating facts, 
now stated in the description: the wrapped form was one of the either-shape 
outcomes on trunk and 3.5.x (the registration picked a writer per start), so a 
client calling `getJSONObject("RemoteException")` was already failing on every 
start that picked Jackson — and `TimelineServer.md` never documented the 
wrapped form. Changes:
   
   - the description's shape table gained an error-body row, and the 
compatibility paragraph states the before/after;
   - `TestTimelineWebServices#testErrorResponseBodyIsNotWrapped` GETs a missing 
entity and asserts a 404 whose body keeps `exception`, `message` and 
`javaClassName` at the top level with no `RemoteException` wrapper;
   - the Jira release note mentions the error-body change alongside the other 
shape changes.
   
   With the error-body case added, the full AHS module suite against a fully 
reseeded local SNAPSHOT set runs 214/214.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to