[ 
https://issues.apache.org/jira/browse/HADOOP-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455589#comment-13455589
 ] 

Vinod Kumar Vavilapalli commented on HADOOP-8733:
-------------------------------------------------

Looks good overall, Ivan.

One minor point: In TestJvmManager, instead of creating dummy file for WINDOWS, 
will it be possible to simulate the Child code like on Linux. Is "final String 
jvmName = ManagementFactory.getRuntimeMXBean().getName();" in Child.java the 
call that is used to send pid from Child to TT? If so, we should just simulate 
that code.
                
> TestStreamingTaskLog, TestJvmManager, TestLinuxTaskControllerLaunchArgs fail 
> on Windows
> ---------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8733
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8733
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 1-win
>            Reporter: Ivan Mitic
>            Assignee: Ivan Mitic
>         Attachments: HADOOP-8733-scripts.2.patch, 
> HADOOP-8733-scripts.2.patch, HADOOP-8733-scripts.patch
>
>
> Jira tracking test failures related to test .sh script dependencies. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to