[
https://issues.apache.org/jira/browse/HADOOP-8733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456158#comment-13456158
]
Ivan Mitic commented on HADOOP-8733:
------------------------------------
Thanks again for reviewing Vinod!
bq. One minor point: In TestJvmManager, instead of creating dummy file for
WINDOWS, will it be possible to simulate the Child code like on Linux. Is
"final String jvmName = ManagementFactory.getRuntimeMXBean().getName();" in
Child.java the call that is used to send pid from Child to TT? If so, we should
just simulate that code.
I'm not sure I understand your comment. Do you mind clarifying a bit?
Just to provide some context from my side. On Windows, we don't use ProcessID
to identify the task process, instead we used attemptId string. This ID is tied
to the child task using Windows
[JobObjects|http://msdn.microsoft.com/en-us/library/windows/desktop/ms684161(v=vs.85).aspx],
and TT uses this ID to kill the task if needed.
Now, in TestJvmManager we are verifying that the task is killed properly, and
on Windows there is no need to circulate the PID from the task back to the TT,
as the TT has this info already. Hope this helps.
> TestStreamingTaskLog, TestJvmManager, TestLinuxTaskControllerLaunchArgs fail
> on Windows
> ---------------------------------------------------------------------------------------
>
> Key: HADOOP-8733
> URL: https://issues.apache.org/jira/browse/HADOOP-8733
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8733-scripts.2.patch,
> HADOOP-8733-scripts.2.patch, HADOOP-8733-scripts.patch
>
>
> Jira tracking test failures related to test .sh script dependencies.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
