[ 
https://issues.apache.org/jira/browse/HADOOP-8973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483599#comment-13483599
 ] 

Chris Nauroth commented on HADOOP-8973:
---------------------------------------

One other note on that patch: I also noticed a bug in TestDiskChecker.java.  
The _checkDirs helper method was not using the isDir flag.  This meant that the 
test case testCheckDir_notDir_local was not really testing what it intended.  I 
updated _checkDirs to make use of the flag.  If isDir is true, then the test 
runs against a directory.  If isDir is false, then the test runs against a file.

All of these tests pass on Mac and Windows with this patch.

                
> DiskChecker cannot reliably detect an inaccessible disk on Windows with NTFS 
> ACLs
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-8973
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8973
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8973-branch-trunk-win.patch
>
>
> DiskChecker.checkDir uses File.canRead, File.canWrite, and File.canExecute to 
> check if a directory is inaccessible.  These APIs are not reliable on Windows 
> with NTFS ACLs due to a known JVM bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to