[ 
https://issues.apache.org/jira/browse/HADOOP-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8977:
----------------------------------

    Attachment: HADOOP-8977-branch-trunk-win.patch

Thanks, Daryn.  I tested multiple different attempts at translating the File 
back to a workable path, including File.toUri().toString().  Unfortunately, on 
Windows, taking a trip through java.io.File always converts '/' to '\', no 
matter what additional API calls you make on it.

I'm attaching an alternative patch that keeps the PathData(FileSystem) 
constructor private like you requested, but changes the public PathData(File) 
constructor to PathData(URI) and updates all call sites.  URI doesn't suffer 
from the same problem as File.  This passes on Mac and Windows.

What do you think of this version of the patch?

                
> multiple FsShell test failures on Windows
> -----------------------------------------
>
>                 Key: HADOOP-8977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8977
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8977-branch-trunk-win.patch, 
> HADOOP-8977-branch-trunk-win.patch
>
>
> Multiple FsShell-related tests fail on Windows.  Commands are returning 
> non-zero exit status.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to