[ 
https://issues.apache.org/jira/browse/HADOOP-8977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493523#comment-13493523
 ] 

Arpit Agarwal commented on HADOOP-8977:
---------------------------------------

The PathData public constructor change in the 10/31 patch looks okay to me 
since the interface is labeled private and unstable. Unfortunate that File 
mangles the forward slashes.

+1 (non-binding). Reviewed and ran the following tests which all passed:
- TestFsShellCopy
- TestFsShellReturnCode
- TestTextCommand
- TestPath
- TestPathData
                
> multiple FsShell test failures on Windows
> -----------------------------------------
>
>                 Key: HADOOP-8977
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8977
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8977-branch-trunk-win.patch, 
> HADOOP-8977-branch-trunk-win.patch, HADOOP-8977-branch-trunk-win.patch
>
>
> Multiple FsShell-related tests fail on Windows.  Commands are returning 
> non-zero exit status.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to