[ 
https://issues.apache.org/jira/browse/HADOOP-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13494240#comment-13494240
 ] 

Raja Aluri commented on HADOOP-9011:
------------------------------------

This part of the code seems unrelated to the change. (changing the variable 
name)
Since it is a trivial change, +1 for the change.
{code}
-    current_branch = filter_current_branch.search(branch).group(1).strip()
-    url = "%s on branch %s" % (origin, current_branch)
+    branch = filter_current_branch.search(branch).group(1).strip()
+    url = "%s on branch %s" % (origin, branch)
{code}

                
> saveVersion.py does not include branch in version annotation
> ------------------------------------------------------------
>
>                 Key: HADOOP-9011
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9011
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9011-branch-trunk-win.patch
>
>
> HADOOP-8924 created saveVersion.py on branch-trunk-win.  Unlike 
> saveVersion.sh on trunk, it did not include the branch attribute in the 
> version annotation.  This causes errors at runtime for anything that tries to 
> read the annotation via VersionInfo.  This also causes a unit test failure in 
> TestYarnVersionInfo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to