[ 
https://issues.apache.org/jira/browse/HADOOP-9011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13495536#comment-13495536
 ] 

Chris Nauroth commented on HADOOP-9011:
---------------------------------------

Thank you, Raja.  While working on this, I noticed that the name current_branch 
was inconsistent with the rest of the code.  For all other substitutions into 
the annotation, the script variable name matches the annotation variable name 
(version, revision, user, etc.).  To make the code more consistent, I renamed 
current_branch to branch.  This didn't seem significant enough to warrant 
splitting it into a separate jira.
                
> saveVersion.py does not include branch in version annotation
> ------------------------------------------------------------
>
>                 Key: HADOOP-9011
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9011
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9011-branch-trunk-win.patch
>
>
> HADOOP-8924 created saveVersion.py on branch-trunk-win.  Unlike 
> saveVersion.sh on trunk, it did not include the branch attribute in the 
> version annotation.  This causes errors at runtime for anything that tries to 
> read the annotation via VersionInfo.  This also causes a unit test failure in 
> TestYarnVersionInfo.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to