[
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557430#comment-13557430
]
Suresh Srinivas commented on HADOOP-8924:
-----------------------------------------
Looking at the code VersionInfo.java code looks like it can be improved. It has
_get* instance methods and get* static methods. These static methods are hidden
by other classes that extend this class. Is it not possible to use one
implementation of VersionInfo? All that I see different between variants of
this class is how they decide on the properties file to read. So instead of
passing {{component}} name in the constructor, can the properties name be
passed?
In pom.xml file, the change where in resources *-version-info.properties seems
to be both included and excluded. Adding a brief comment on why this is being
done will help understanding.
> Hadoop Common creating package-info.java must not depend on sh, at least for
> Windows
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-8924
> URL: https://issues.apache.org/jira/browse/HADOOP-8924
> Project: Hadoop Common
> Issue Type: Improvement
> Components: build
> Affects Versions: trunk-win
> Reporter: Chris Nauroth
> Assignee: Alejandro Abdelnur
> Fix For: trunk-win
>
> Attachments: HADOOP-8924.2.patch, HADOOP-8924.3.patch,
> HADOOP-8924.3.patch, HADOOP-8924.4.patch, HADOOP-8924.5.patch,
> HADOOP-8924-branch-trunk-win.2.patch, HADOOP-8924-branch-trunk-win.3.patch,
> HADOOP-8924-branch-trunk-win.4.patch, HADOOP-8924-branch-trunk-win.5.patch,
> HADOOP-8924-branch-trunk-win.patch, HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate
> package-info.java with a version annotation. The sh binary may not be
> available on all developers' machines (e.g. Windows without Cygwin). This
> issue tracks removal of that dependency in Hadoop Common.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
