[ 
https://issues.apache.org/jira/browse/HADOOP-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562749#comment-13562749
 ] 

Hadoop QA commented on HADOOP-9247:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12566513/HADOOP-9247-trunk.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2093//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2093//console

This message is automatically generated.
                
> parametrize Clover "generateXxx" properties to make them re-definable via -D 
> in mvn calls
> -----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9247
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9247
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
>            Reporter: Ivan A. Veselovsky
>            Assignee: Ivan A. Veselovsky
>            Priority: Minor
>         Attachments: HADOOP-9247-trunk.patch
>
>
> The suggested parametrization is needed in order 
> to be able to re-define these properties with "-Dk=v" maven options.
> For some reason the expressions declared in clover 
> docs like "${maven.clover.generateHtml}" (see 
> http://docs.atlassian.com/maven-clover2-plugin/3.0.2/clover-mojo.html) do not 
> work in that way. 
> However, the parametrized properties are confirmed to work: e.g. 
> -DcloverGenHtml=false switches off the Html generation, if defined 
> <generateHtml>${cloverGenHtml}</generateHtml>.
> The default values provided here exactly correspond to Clover defaults, so
> the behavior is 100% backwards compatible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to