[
https://issues.apache.org/jira/browse/HADOOP-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562979#comment-13562979
]
Chris Nauroth commented on HADOOP-9247:
---------------------------------------
+1 The patch looks good. I applied it to a local copy of trunk and tested
using -DcloverGenXml=false to suppress XML generation.
FYI, it appears that the HADOOP-8924 change to calculate version info using a
Maven plugin is not playing well with Clover. When I ran with -Pclover, I was
getting the error below. I had to make a change in
hadoop-maven-plugins/pom.xml to work around it. The problem is unrelated to
this patch, so I filed HADOOP-9249 to follow up separately.
{code}
[INFO] --- hadoop-maven-plugins:3.0.0-SNAPSHOT:version-info (version-info) @
hadoop-common ---
[CLOVER] FATAL ERROR: Clover could not be initialised. Are you sure you have
Clover in the runtime classpath? (class
java.lang.NoClassDefFoundError:com_cenqua_clover/CloverVersionInfo)
...
[ERROR] Failed to execute goal
org.apache.hadoop:hadoop-maven-plugins:3.0.0-SNAPSHOT:version-info
(version-info) on project hadoop-common: Execution version-info of goal
org.apache.hadoop:hadoop-maven-plugins:3.0.0-SNAPSHOT:version-info failed: A
required class was missing while executing
org.apache.hadoop:hadoop-maven-plugins:3.0.0-SNAPSHOT:version-info:
com_cenqua_clover/CoverageRecorder
{code}
> parametrize Clover "generateXxx" properties to make them re-definable via -D
> in mvn calls
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-9247
> URL: https://issues.apache.org/jira/browse/HADOOP-9247
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Ivan A. Veselovsky
> Assignee: Ivan A. Veselovsky
> Priority: Minor
> Attachments: HADOOP-9247-trunk.patch
>
>
> The suggested parametrization is needed in order
> to be able to re-define these properties with "-Dk=v" maven options.
> For some reason the expressions declared in clover
> docs like "${maven.clover.generateHtml}" (see
> http://docs.atlassian.com/maven-clover2-plugin/3.0.2/clover-mojo.html) do not
> work in that way.
> However, the parametrized properties are confirmed to work: e.g.
> -DcloverGenHtml=false switches off the Html generation, if defined
> <generateHtml>${cloverGenHtml}</generateHtml>.
> The default values provided here exactly correspond to Clover defaults, so
> the behavior is 100% backwards compatible.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
