[
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583562#comment-13583562
]
Suresh Srinivas commented on HADOOP-9318:
-----------------------------------------
This is a useful functionality.
Comments:
# Please add javadoc to the methods
# Minor nits - in register() method, create StringBuilder after the first check
that throws exception. Optionally, is it better to throw IllegalStateException
instead RTE?
# Given the way Handler code is, you just need only a single instance of
Handler. It can be registered in the register method itself using
{{signal.handle()}} call right?
> when exiting on a signal, print the signal name first
> -----------------------------------------------------
>
> Key: HADOOP-9318
> URL: https://issues.apache.org/jira/browse/HADOOP-9318
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.4-beta
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-9318.001.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a
> signal. For example, if a daemon exited because the system administrator
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it
> would be nice to have it be explicit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
