[ 
https://issues.apache.org/jira/browse/HADOOP-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13600796#comment-13600796
 ] 

Suresh Srinivas commented on HADOOP-9318:
-----------------------------------------

Aaron, thanks for checking.

bq. Each instance of Handler handles a different signal. Keep in mind that 
prevHandler will be different for each signal, so if we combined them all into 
one, we'd have to have some kind of Map or something to be able to call the 
correct prevHandler. So I think it's easier to leave them separate.
Perhaps I do not understand the code correctly. Given that all a handler is 
doing is just printing a log, using a single instance of handler should be 
sufficient and need for separate instance does not seem necessary, unless 
different actions need to be taken for each signal. Again, this is not a big 
deal.

                
> when exiting on a signal, print the signal name first
> -----------------------------------------------------
>
>                 Key: HADOOP-9318
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9318
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.5-beta
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-9318.001.patch, HADOOP-9318.002.patch, 
> HADOOP-9318.003.patch
>
>
> On UNIX, it would be nice to know when a Hadoop daemon had exited on a 
> signal.  For example, if a daemon exited because the system administrator 
> sent SIGTERM (i.e. {{killall java}}), it would be nice to know that.  
> Although some of this can be deduced from context and {{SHUTDOWN_MSG}}, it 
> would be nice to have it be explicit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to