[ 
https://issues.apache.org/jira/browse/HADOOP-9380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602708#comment-13602708
 ] 

Luke Lu commented on HADOOP-9380:
---------------------------------

Thanks for the patch, Sanjay! A few issues for the v2 patch:

# _All_ responses (not just regular rpc responses) need to have a total length 
prefix (symmetric to the server request handling). i.e., we also need it for 
bad version, serialization and sasl etc. responses. Otherwise, we still can't 
have non-blocking clients.
# We should use exceptions instead of asserts for for total length checking at 
client side, as mismatch can happen due to server fault/network disconnect etc.
                
> Add totalLength to rpc response
> -------------------------------
>
>                 Key: HADOOP-9380
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9380
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: HADOOP-9380-2.patch, HADOOP-9380.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to