[
https://issues.apache.org/jira/browse/HADOOP-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13616997#comment-13616997
]
Hadoop QA commented on HADOOP-9443:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12576002/HADOOP-9443-trunk.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2379//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2379//console
This message is automatically generated.
> Port winutils static code analysis change to trunk
> --------------------------------------------------
>
> Key: HADOOP-9443
> URL: https://issues.apache.org/jira/browse/HADOOP-9443
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Chuan Liu
> Assignee: Chuan Liu
> Attachments: HADOOP-9443-trunk.patch
>
>
> We hit a problem in winutils when running tests on Windows. The static code
> analysis change will fix the problem. More specifically, the old code always
> assumes the security descriptor get from GetSecurityDescriptorControl() is
> relative, and will make an absolute security descriptor out of it. The new
> absolute security descriptor will then pass to SetSecurityDescriptorDacl() to
> set permissions on the file. If the security descriptor is absolute, the new
> absolute security descriptor will be NULL, and we will run into the problem.
> This is what happened exactly in our case. The fix from static code analysis
> will solve the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
