[ 
https://issues.apache.org/jira/browse/HADOOP-9443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637530#comment-13637530
 ] 

Hudson commented on HADOOP-9443:
--------------------------------

Integrated in Hadoop-Yarn-trunk #190 (See 
[https://builds.apache.org/job/Hadoop-Yarn-trunk/190/])
    HADOOP-9443. Port winutils static code analysis change to trunk. 
Contributed by Chuan Liu. (Revision 1470224)

     Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1470224
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/chmod.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/chown.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/groups.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/hardlink.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/include/winutils.h
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/libwinutils.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/ls.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/main.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/symlink.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/systeminfo.c
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/winutils/task.c

                
> Port winutils static code analysis change to trunk
> --------------------------------------------------
>
>                 Key: HADOOP-9443
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9443
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Chuan Liu
>            Assignee: Chuan Liu
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-9443-trunk.patch
>
>
> We hit a problem in winutils when running tests on Windows. The static code 
> analysis change will fix the problem. More specifically, the old code always 
> assumes the security descriptor get from GetSecurityDescriptorControl() is 
> relative, and will make an absolute security descriptor out of it. The new 
> absolute security descriptor will then pass to SetSecurityDescriptorDacl() to 
> set permissions on the file. If the security descriptor is absolute, the new 
> absolute security descriptor will be NULL, and we will run into the problem. 
> This is what happened exactly in our case. The fix from static code analysis 
> will solve the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to