[ 
https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13681360#comment-13681360
 ] 

Daryn Sharp commented on HADOOP-9421:
-------------------------------------

bq. I don't think ID_TOKEN or SSO_TOKEN being appropriate in 
SaslRpcServer.AuthMethod.
No worries, this will eventually become dynamic and not live in the rpc server 
class since we can't afford to change the code every time we add a new 
AuthMethod.  At the moment, I'm only trying to make the minimal changes to the 
base wire protocol to allow future extensibility.

bq.  Challenge response is the main performance use case that's worth 
optimizing for.
All SASL mechanisms are challenge/response, not just tokens...

We can continue on another jira, but I think you are predicating the 
optimization on the assumption the client can always pre-determine the 
AuthMethod to use.  That's one of the fundamental flaws with the current 
implementation.  When there are more supported auths and more supported tokens, 
the client's initial connection has no way to know which to chose until the 
server tells it what it needs.  We might be able to optimize a re-connect but 
it's going to further complicate and delay this jira.

To put this all in perspective, we're holding up the base SASL RPCv9 changes to 
discuss a pre-mature optimization to avoid sending <100 bytes, compared to 
token negotiation requiring at least 5X more bytes, and kerberos requiring at 
least 20X more bytes.  Both of these are dwarfed by the real activity over the 
connection which why I feel we should defer to another jira.
                
> Convert SASL to use ProtoBuf and add lengths for non-blocking processing
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-9421
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9421
>             Project: Hadoop Common
>          Issue Type: Sub-task
>    Affects Versions: 2.0.3-alpha
>            Reporter: Sanjay Radia
>            Assignee: Daryn Sharp
>         Attachments: HADOOP-9421.patch, HADOOP-9421.patch, HADOOP-9421.patch, 
> HADOOP-9421.patch, HADOOP-9421-v2-demo.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to