[
https://issues.apache.org/jira/browse/HADOOP-9421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13689336#comment-13689336
]
Luke Lu commented on HADOOP-9421:
---------------------------------
bq. I don't understand the advantage of this patch. At a minimum, here are
major problems.
I think you misunderstood the patch and the current flow as well. In the
["Current
flow"|https://issues.apache.org/jira/browse/HADOOP-9421?focusedCommentId=13688055&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13688055],
step 1 and 2 is in the same C->S packet.
My patch is an improvement over yours in that challenge or negotiation is not
done blindly. It can support SCRAM/Kerberos round-trip reduction with no
protocol branching while yours cannot.
Conceptually I just replace the step 2 (still part of the connection header
packet) with wrapped RpcSaslProto to allow future extensibility. So my patch
feature wise is a superset of yours.
> Convert SASL to use ProtoBuf and add lengths for non-blocking processing
> ------------------------------------------------------------------------
>
> Key: HADOOP-9421
> URL: https://issues.apache.org/jira/browse/HADOOP-9421
> Project: Hadoop Common
> Issue Type: Sub-task
> Affects Versions: 2.0.3-alpha
> Reporter: Sanjay Radia
> Assignee: Daryn Sharp
> Priority: Blocker
> Attachments: HADOOP-9421.patch, HADOOP-9421.patch, HADOOP-9421.patch,
> HADOOP-9421.patch, HADOOP-9421.patch, HADOOP-9421.patch, HADOOP-9421.patch,
> HADOOP-9421.patch, HADOOP-9421-v2-demo.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
