[ 
https://issues.apache.org/jira/browse/HADOOP-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704976#comment-13704976
 ] 

Konstantin Shvachko commented on HADOOP-9688:
---------------------------------------------

Sorry for coming late to this.
The idea to use ClientId + CallId as a unique combination of the call is 
absolutely right.
= One question if the ClientId should be on the RPC client or DFSClient. Now 
both have an id, which makes one of them redundant.
= randomUUID is not unique. Even though as Chris commented the probability of a 
collision is low there are ways to generate really unique clientIds, say as we 
generate storageIDs for DataNodes. Should we target that?
= The naming of the new field could be confusing. You call it uuid in the 
Client and clientId in other places, if I understood it correctly.
                
> Add globally unique Client ID to RPC requests
> ---------------------------------------------
>
>                 Key: HADOOP-9688
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9688
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-9688.clientId.1.patch, 
> HADOOP-9688.clientId.patch, HADOOP-9688.patch
>
>
> This is a subtask in hadoop-common related to HDFS-4942 to add unique request 
> ID to RPC requests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to