[
https://issues.apache.org/jira/browse/HADOOP-9688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705032#comment-13705032
]
Suresh Srinivas commented on HADOOP-9688:
-----------------------------------------
[~shv] Thanks for the comments.
bq. One question if the ClientId should be on the RPC client or DFSClient. Now
both have an id, which makes one of them redundant.
Having it in RPC client avoids collision. If it were in DFSClient, across all
the clients, call ID needs to be generated such that there is no collision.
bq. randomUUID is not unique. Even though as Chris commented the probability of
a collision is low there are ways to generate really unique clientIds, say as
we generate storageIDs for DataNodes. Should we target that?
I think randomUUID collision probability is very low. If not better, it should
not be worse than storageID. See some links from my previous comment -
https://issues.apache.org/jira/browse/HADOOP-9688?focusedCommentId=13702321&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13702321
Also note that the uniqueness is lot simpler here. The uniqueness we need is
for the period of retry cache (around 10 minutes). Hence probability of
collision should be even lower.
bq. The naming of the new field could be confusing. You call it uuid in the
Client and clientId in other places, if I understood it correctly.
Good idea. I will file another jira to rename the field to client ID. Also
document the field.
> Add globally unique Client ID to RPC requests
> ---------------------------------------------
>
> Key: HADOOP-9688
> URL: https://issues.apache.org/jira/browse/HADOOP-9688
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Priority: Blocker
> Fix For: 3.0.0
>
> Attachments: HADOOP-9688.clientId.1.patch,
> HADOOP-9688.clientId.patch, HADOOP-9688.patch
>
>
> This is a subtask in hadoop-common related to HDFS-4942 to add unique request
> ID to RPC requests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
