[
https://issues.apache.org/jira/browse/HADOOP-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719005#comment-13719005
]
Tsz Wo (Nicholas), SZE commented on HADOOP-9756:
------------------------------------------------
Hi Junping, thanks for working on this. Please remove all other
RPC.getServer(..) methods. They were deprecated by HADOOP-8754. You may
replace the existing usage of them by RPC.Builder.
For narrowing "throws Exception", I notices that the changes are only happened
in the tests. You may skip the them next time. I think it is better to focus
on the main code and don't waste our energy on the style of the test code. :)
> Additional cleanup RPC code
> ---------------------------
>
> Key: HADOOP-9756
> URL: https://issues.apache.org/jira/browse/HADOOP-9756
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Reporter: Junping Du
> Assignee: Junping Du
> Priority: Minor
> Attachments: HADOOP-9756.patch
>
>
> HADOOP-9754 already did good job to address most of work for cleanup RPC
> code. Here is some additional work, include:
> - Remove some unused deprecated code.
> - Narrow "throws Exception" to throw some specific exception and remove some
> unnecessary exceptions
> - Fix a generic warning and correct spell issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
