[ 
https://issues.apache.org/jira/browse/HADOOP-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719364#comment-13719364
 ] 

Hadoop QA commented on HADOOP-9756:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12594097/HADOOP-9756-v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

                  org.apache.hadoop.mapreduce.v2.TestNonExistentJob
                  org.apache.hadoop.mapreduce.security.TestBinaryTokenFile
                  org.apache.hadoop.mapreduce.security.TestMRCredentials
                  org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2843//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/2843//console

This message is automatically generated.
                
> Additional cleanup RPC code
> ---------------------------
>
>                 Key: HADOOP-9756
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9756
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Junping Du
>            Assignee: Junping Du
>            Priority: Minor
>         Attachments: HADOOP-9756.patch, HADOOP-9756-v2.patch
>
>
> HADOOP-9754 already did good job to address most of work for cleanup RPC 
> code. Here is some additional work, include:
> - Remove some unused deprecated code.
> - Narrow "throws Exception" to throw some specific exception and remove some 
> unnecessary exceptions
> - Fix a generic warning and correct spell issue.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to