[
https://issues.apache.org/jira/browse/HADOOP-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722584#comment-13722584
]
Hadoop QA commented on HADOOP-9779:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12594712/HADOOP-9779.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2863//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2863//console
This message is automatically generated.
> create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16
> everywhere
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-9779
> URL: https://issues.apache.org/jira/browse/HADOOP-9779
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HADOOP-9779.1.patch
>
>
> We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than
> hard-coding the number 16 everywhere.
> Sun Java coding style convention 10.3:
> bq. Numerical constants (literals) should not be coded directly, except for
> -1, 0, and 1, which can appear in a for loop as counter values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
