[
https://issues.apache.org/jira/browse/HADOOP-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726670#comment-13726670
]
Colin Patrick McCabe commented on HADOOP-9779:
----------------------------------------------
Thanks for looking at this, Tsuyoshi. However, I think I agree with Suresh
here-- HDFS-5025 probably did all we need for the client ID length. I don't
see any need for {{RpcConstants.CLIENT_ID_LENGTH}} if all it is used for is
initializing {{ClientId.BYTE_LENGTH}}.
bq. 2. RetryCache constructor uses maxCapacity instead of hardcoded 16.
Unless I'm misunderstanding something, this change doesn't seem related to the
client ID length. I would suggest a separate JIRA for this one to avoid
confusion.
So:
* close this as a duplicate of HDFS-5025?
* create separate JIRA for RetryCache constants?
sound good?
> create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16
> everywhere
> -----------------------------------------------------------------------------------
>
> Key: HADOOP-9779
> URL: https://issues.apache.org/jira/browse/HADOOP-9779
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HADOOP-9779.1.patch, HADOOP-9779.2.patch
>
>
> We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than
> hard-coding the number 16 everywhere.
> Sun Java coding style convention 10.3:
> bq. Numerical constants (literals) should not be coded directly, except for
> -1, 0, and 1, which can appear in a for loop as counter values.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
