[ 
https://issues.apache.org/jira/browse/HADOOP-9160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13730061#comment-13730061
 ] 

Luke Lu commented on HADOOP-9160:
---------------------------------

bq. Making it optional is pretty straightforward.

As I pointed out in the previous review, the patch needs to be improved to 
incorporate hadoop authz (HttpServer#isInstrumentationAccessAllowed for read 
and HttpServer#hasAdministratorAccess for write), which would involve a simple 
wrapper to extend the original AgentServlet. I think a _compile_ time 
dependency (a la jersey) would be more appropriate if you really want the 
runtime dependency to be optional.

OTOH, I personally prefer a static dependency for simplicity and UX, because if 
a user enables jolokia and the jar is not not there, there'd be another cryptic 
class not found error in the log to chase down. jolokia-core jar is only 200+KB 
which is a small fraction of common dependencies.

bq. it may end up on the classpath of client side apps.

The hadoop-client module (HADOOP-8009) should address most of the client side 
issues. For YARN app side dependencies, monitoring too useful to save the 200KB 
initial dist cache copies...


                
> Adopt Jolokia as the JMX HTTP/JSON bridge.
> ------------------------------------------
>
>                 Key: HADOOP-9160
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9160
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Luke Lu
>            Assignee: Junping Du
>              Labels: features
>         Attachments: hadoop-9160-demo-branch-1.txt, HADOOP-9160.patch
>
>
> The current JMX HTTP bridge has served its purpose, while a more complete 
> solution: Jolokia (formerly Jmx4Perl) has been developed/matured over the 
> years.
> Jolokia provides comprehensive JMX features over HTTP/JSON including search 
> and list of JMX attributes and operations metadata, which helps to support 
> inter framework/platform compatibility. It has first class language bindings 
> for Perl, Python, Javascript, Java.
> It's trivial (see demo patch) to incorporate Jolokia servlet into Hadoop HTTP 
> servers and use the same security mechanisms.
> Adopting Jolokia will substantially improve the manageability of Hadoop and 
> its ecosystem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to