[
https://issues.apache.org/jira/browse/HADOOP-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769818#comment-13769818
]
Brandon Li commented on HADOOP-9669:
------------------------------------
Thanks, Haohui. Some comments:
1. please try to keep the original javadoc for the same named methods
2. can you make "State state" as final?
3. please fix the javadoc /** check if the rest of data has more than <len>
bytes */
"len" is not visible in generated javadoc
4. readFixedOpaque still has a copy
not sure if it's possible to generat a read-only bytebuffer from another
bytebuffer
5. it would be nice to remove the extra copy for writeFixedOpaque
For 4 and 5, I am ok if you think it's out of scope of this JIRA.
> There are multiple array creations and array copies for a single nfs rpc reply
> ------------------------------------------------------------------------------
>
> Key: HADOOP-9669
> URL: https://issues.apache.org/jira/browse/HADOOP-9669
> Project: Hadoop Common
> Issue Type: Improvement
> Components: nfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Haohui Mai
> Attachments: HADOOP-9669.001.patch, HADOOP-9669.patch
>
>
> XDR.writeXxx(..) methods ultimately use the static XDR.append(..) for writing
> each data type. The static append creates a new array and copy data.
> Therefore, for a singe reply such as RpcAcceptedReply.voidReply(..), there
> are multiple array creations and array copies. For example, there are at
> least 6 array creations and array copies for RpcAcceptedReply.voidReply(..).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
