[
https://issues.apache.org/jira/browse/HADOOP-9669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13769940#comment-13769940
]
Brandon Li commented on HADOOP-9669:
------------------------------------
+1. New patch looks good.
Nit: I noticed that most NFS related RPC call response size is less than 256
bytes, so we can have DEFAULT_INITIAL_CAPACITY as 256 instead of 512.
> There are multiple array creations and array copies for a single nfs rpc reply
> ------------------------------------------------------------------------------
>
> Key: HADOOP-9669
> URL: https://issues.apache.org/jira/browse/HADOOP-9669
> Project: Hadoop Common
> Issue Type: Improvement
> Components: nfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Haohui Mai
> Attachments: HADOOP-9669.001.patch, HADOOP-9669.002.patch,
> HADOOP-9669.patch
>
>
> XDR.writeXxx(..) methods ultimately use the static XDR.append(..) for writing
> each data type. The static append creates a new array and copy data.
> Therefore, for a singe reply such as RpcAcceptedReply.voidReply(..), there
> are multiple array creations and array copies. For example, there are at
> least 6 array creations and array copies for RpcAcceptedReply.voidReply(..).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
