[ 
https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13817150#comment-13817150
 ] 

Steve Loughran commented on HADOOP-10085:
-----------------------------------------

# the Concurrency modification is a bug in the composite service -one that 
showed up first in the HA RM, but something fairly basic.
# the stricter state of additions goes one further and ensures that the next 
state transition of the composite will not fail due to an illegal state 
transition attempt of a child.

Lots of child services are added by containers, and I've got some that actually 
make the {{addService}} method public for better service composition. The check 
locks down what state the children can be in and stops people making mistakes 
-at the time of insertion, not state transition.

> CompositeService should allow adding services while being inited
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10085
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10085
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.2.0
>            Reporter: Karthik Kambatla
>            Assignee: Steve Loughran
>         Attachments: HADOOP-10085-002.patch
>
>
> We can add services to a CompositeService. However, if we do that while 
> initing the CompositeService, it leads to a ConcurrentModificationException.
> It would be nice to allow adding services even during the init of 
> CompositeService.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to