[
https://issues.apache.org/jira/browse/HADOOP-10085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887911#comment-13887911
]
Karthik Kambatla commented on HADOOP-10085:
-------------------------------------------
Really like the use of AddBlockingService.
Comments:
# Is there a need for the static method AddBlockingService#addChildService()?
Why not just call parent.addService?
# Nit: Would be nice to have the tests in an order - adding (Uninited, Inited,
Started, Stopped) children to Uninited parent, Inited parent etc. - 16 tests in
all. Then, the test serves as a rubric for someone to understand the behavior.
# Nit: Rename testAddSiblingInStart to testAddStartedSiblingInStart
# Nit: Rename testAddSiblingInStop to testAddStartedSiblingInStop
# Nit: Rename testAddSiblingInInit to testAddInitedSiblingInInit
> CompositeService should allow adding services while being inited
> ----------------------------------------------------------------
>
> Key: HADOOP-10085
> URL: https://issues.apache.org/jira/browse/HADOOP-10085
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.2.0
> Reporter: Karthik Kambatla
> Assignee: Steve Loughran
> Attachments: HADOOP-10085-002.patch, HADOOP-10085-003.patch,
> HADOOP-10085-004.patch
>
>
> We can add services to a CompositeService. However, if we do that while
> initing the CompositeService, it leads to a ConcurrentModificationException.
> It would be nice to allow adding services even during the init of
> CompositeService.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
