[
https://issues.apache.org/jira/browse/HADOOP-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823575#comment-13823575
]
Steve Loughran commented on HADOOP-10100:
-----------------------------------------
This patch also changed the junit dependencies. Was that intentional? If not it
slipped through review & also needs to be in the title of the patch/changes
Pushing through potentially significant changes in dependencies and export in
3h, without even a chance of those people who are working on actually updating
al
# Please don't change multiple dependencies in one go as we are trying to do
them one by one -with careful review.
# This wasn't a critical "fix in hours our disaster" patch, so I'd have liked
to have been given an opportunity to review -which I would have done by getting
the junit part of the diff moved to a separate patch that also updated the
junit version to 4.11
Now, was the junit patch an accident? If so could we roll it back and have a
separate patch with the junit update, and a separate note in CHANGES.TXT?
> MiniKDC shouldn't use apacheds-all artifact
> -------------------------------------------
>
> Key: HADOOP-10100
> URL: https://issues.apache.org/jira/browse/HADOOP-10100
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.3.0
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Fix For: 2.3.0
>
> Attachments: HADOOP-10100.patch, HADOOP-10100.patch
>
>
> The MiniKDC currently depends on the {{apacheds-all}} artifact:
> {code:xml}
> <dependency>
> <groupId>org.apache.directory.server</groupId>
> <artifactId>apacheds-all</artifactId>
> <version>2.0.0-M15</version>
> <scope>compile</scope>
> </dependency>
> {code}
> However, this artifact includes, inside of itself, a lot of other packages,
> including antlr, ehcache, apache commons, and mina (you can see a full list
> of the packages in the jar
> [here|http://mvnrepository.com/artifact/org.apache.directory.server/apacheds-all/2.0.0-M15]).
> This can be problematic if other projects (e.g. Oozie) try to use MiniKDC
> and have a different version of one of those dependencies (in my case,
> ehcache). Because the packages are included inside the {{apacheds-all}} jar,
> we can't override their version.
> Instead, we should remove {{apacheds-all}} and use dependencies that only
> include org.apache.directory.* packages; the other necessary dependencies
> should be included normally.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
