[ 
https://issues.apache.org/jira/browse/HADOOP-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13823975#comment-13823975
 ] 

Alejandro Abdelnur commented on HADOOP-10100:
---------------------------------------------

[[email protected]],

This patch does not change junit version at all as running "mvn 
dependency:tree" before and after the patch show. 

*Before:*

{code}
[INFO] --- maven-dependency-plugin:2.2:tree (default-cli) @ hadoop-minikdc ---
[INFO] org.apache.hadoop:hadoop-minikdc:jar:3.0.0-SNAPSHOT
[INFO] +- commons-io:commons-io:jar:2.1:compile
[INFO] +- org.apache.directory.server:apacheds-all:jar:2.0.0-M15:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.5:compile
[INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.5:compile
[INFO] |  \- log4j:log4j:jar:1.2.17:compile
[INFO] \- junit:junit:jar:4.10:compile
[INFO]    \- org.hamcrest:hamcrest-core:jar:1.1:compile
{code}

*After* (I've prefixed with a '*' the non apache-ds dependencies which are not 
apache-ds, they all have the same version as before the patch):

{code}
[INFO] --- maven-dependency-plugin:2.2:tree (default-cli) @ hadoop-minikdc ---
[INFO] org.apache.hadoop:hadoop-minikdc:jar:3.0.0-SNAPSHOT
* [INFO] +- commons-io:commons-io:jar:2.1:compile
[INFO] +- org.apache.directory.server:apacheds-core-api:jar:2.0.0-M15:compile
[INFO] |  +- commons-lang:commons-lang:jar:2.5:compile (version managed from 
2.6)
[INFO] |  +- 
org.apache.directory.server:apacheds-core-constants:jar:2.0.0-M15:compile
[INFO] |  +- org.apache.directory.server:apacheds-i18n:jar:2.0.0-M15:compile
[INFO] |  +- org.apache.directory.api:api-i18n:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-asn1-api:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-client-api:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-codec-core:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-extras-aci:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-extras-util:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-model:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-util:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.mina:mina-core:jar:2.0.0-M5:compile
[INFO] |  +- net.sf.ehcache:ehcache-core:jar:2.4.4:compile
[INFO] |  \- org.slf4j:slf4j-api:jar:1.7.5:compile
[INFO] +- 
org.apache.directory.server:apacheds-interceptor-kerberos:jar:2.0.0-M15:compile
[INFO] |  +- org.apache.directory.server:apacheds-core:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-admin:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-authn:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-authz:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-changelog:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-collective:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-event:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-exception:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-journal:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-normalization:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-operational:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-referral:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-schema:jar:2.0.0-M15:compile
[INFO] |  |  +- 
org.apache.directory.server:apacheds-interceptors-subtree:jar:2.0.0-M15:compile
[INFO] |  |  \- 
org.apache.directory.server:apacheds-interceptors-trigger:jar:2.0.0-M15:compile
[INFO] |  |     \- 
org.apache.directory.api:api-ldap-extras-trigger:jar:1.0.0-M20:compile
[INFO] |  \- 
org.apache.directory.server:apacheds-kerberos-codec:jar:2.0.0-M15:compile
[INFO] +- 
org.apache.directory.server:apacheds-protocol-shared:jar:2.0.0-M15:compile
[INFO] +- 
org.apache.directory.server:apacheds-protocol-kerberos:jar:2.0.0-M15:compile
[INFO] |  \- 
org.apache.directory.server:apacheds-core-shared:jar:2.0.0-M15:compile
[INFO] +- 
org.apache.directory.server:apacheds-ldif-partition:jar:2.0.0-M15:compile
[INFO] |  \- 
org.apache.directory.server:apacheds-xdbm-partition:jar:2.0.0-M15:compile
[INFO] +- 
org.apache.directory.server:apacheds-mavibot-partition:jar:2.0.0-M15:compile
[INFO] |  +- org.apache.directory.mavibot:mavibot:jar:1.0.0-M1:compile
[INFO] |  \- org.apache.directory.server:apacheds-core-avl:jar:2.0.0-M15:compile
[INFO] +- org.apache.directory.api:api-all:jar:1.0.0-M20:compile
[INFO] |  +- commons-pool:commons-pool:jar:1.6:compile
[INFO] |  +- commons-collections:commons-collections:jar:3.2.1:compile
[INFO] |  \- antlr:antlr:jar:2.7.7:compile
[INFO] +- 
org.apache.directory.server:apacheds-jdbm-partition:jar:2.0.0-M15:compile
[INFO] |  \- org.apache.directory.jdbm:apacheds-jdbm1:bundle:2.0.0-M2:compile
[INFO] +- 
org.apache.directory.server:apacheds-protocol-ldap:jar:2.0.0-M15:compile
[INFO] |  +- org.apache.directory.api:api-asn1-ber:jar:1.0.0-M20:compile
[INFO] |  +- 
org.apache.directory.api:api-ldap-extras-codec-api:jar:1.0.0-M20:compile
[INFO] |  +- 
org.apache.directory.api:api-ldap-extras-codec:jar:1.0.0-M20:compile
[INFO] |  +- org.apache.directory.api:api-ldap-extras-sp:jar:1.0.0-M20:compile
[INFO] |  \- bouncycastle:bcprov-jdk15:jar:140:compile
* [INFO] +- org.slf4j:slf4j-log4j12:jar:1.7.5:compile
* [INFO] |  \- log4j:log4j:jar:1.2.17:compile
* [INFO] \- junit:junit:jar:4.10:compile
{code}


> MiniKDC shouldn't use apacheds-all artifact
> -------------------------------------------
>
>                 Key: HADOOP-10100
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10100
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.3.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>             Fix For: 2.3.0
>
>         Attachments: HADOOP-10100.patch, HADOOP-10100.patch
>
>
> The MiniKDC currently depends on the {{apacheds-all}} artifact:
> {code:xml}
>     <dependency>
>       <groupId>org.apache.directory.server</groupId>
>       <artifactId>apacheds-all</artifactId>
>       <version>2.0.0-M15</version>
>       <scope>compile</scope>
>     </dependency>
> {code}
> However, this artifact includes, inside of itself, a lot of other packages, 
> including antlr, ehcache, apache commons, and mina (you can see a full list 
> of the packages in the jar 
> [here|http://mvnrepository.com/artifact/org.apache.directory.server/apacheds-all/2.0.0-M15]).
>   This can be problematic if other projects (e.g. Oozie) try to use MiniKDC 
> and have a different version of one of those dependencies (in my case, 
> ehcache).  Because the packages are included inside the {{apacheds-all}} jar, 
> we can't override their version.  
> Instead, we should remove {{apacheds-all}} and use dependencies that only 
> include org.apache.directory.* packages; the other necessary dependencies 
> should be included normally.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to