[
https://issues.apache.org/jira/browse/HADOOP-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13891566#comment-13891566
]
Hadoop QA commented on HADOOP-10325:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12627039/HADOOP-10325.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3536//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3536//console
This message is automatically generated.
> improve jenkins javadoc warnings from test-patch.sh
> ---------------------------------------------------
>
> Key: HADOOP-10325
> URL: https://issues.apache.org/jira/browse/HADOOP-10325
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10325.001.patch, HADOOP-10325.002.patch
>
>
> Currently test-patch.sh uses {{OK_JAVADOC_WARNINGS}} to know how many
> warnings trunk is expected to have. However, this is a fragile and difficult
> to use system, since different build slaves may generate different numbers of
> warnings (based on compiler revision, etc.). Also, programmers must remember
> to update {{OK_JAVADOC_WARNINGS}}, which they don't always. Finally, there
> is no easy way to find what the *new* javadoc warnings are in the huge pile
> of warnings.
> We should change this to work the same way the javac warnings code does: to
> simply build with and without the patch and do a diff. The diff should be
> saved for easy perusal. We also should not complain about warnings being
> removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
