[
https://issues.apache.org/jira/browse/HADOOP-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13892604#comment-13892604
]
Colin Patrick McCabe commented on HADOOP-10325:
-----------------------------------------------
Good idea. Let me grep for "warning" first. I'll make it case insensitive to
avoid being too selective. (The reason why I think case insensitive is better
is that I think it's better to allow a little spew through than to chop
something really helpful.) The main point is just to let us find the actual
problem in 30 seconds or less, rather than having to search every warning or
download logs.
> improve jenkins javadoc warnings from test-patch.sh
> ---------------------------------------------------
>
> Key: HADOOP-10325
> URL: https://issues.apache.org/jira/browse/HADOOP-10325
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10325.001.patch, HADOOP-10325.002.patch,
> HADOOP-10325.003.patch
>
>
> Currently test-patch.sh uses {{OK_JAVADOC_WARNINGS}} to know how many
> warnings trunk is expected to have. However, this is a fragile and difficult
> to use system, since different build slaves may generate different numbers of
> warnings (based on compiler revision, etc.). Also, programmers must remember
> to update {{OK_JAVADOC_WARNINGS}}, which they don't always. Finally, there
> is no easy way to find what the *new* javadoc warnings are in the huge pile
> of warnings.
> We should change this to work the same way the javac warnings code does: to
> simply build with and without the patch and do a diff. The diff should be
> saved for easy perusal. We also should not complain about warnings being
> removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
