[ 
https://issues.apache.org/jira/browse/HADOOP-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976146#comment-13976146
 ] 

Kihwal Lee commented on HADOOP-10527:
-------------------------------------

bq. We can't throw an IOException because ...
I am not suggesting that. If a lookup successfully returns no result, it is 
supposed to return an empty collection without throwing any exception.

bq. So we need to remove this comment.
Agreed. 

bq. I think we need to get rid of MAX_USER_LOOKUP_TRIES and replace it with a 
maximum buffer size....
What do you think is the reasonable buffer size?

bq. Should use either newRuntimeException or newIOException here.
I think I misread your earlier comment in HADOOP-10522. I understand now. 

> Fix incorrect return code and allow more retries on EINTR
> ---------------------------------------------------------
>
>                 Key: HADOOP-10527
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10527
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Kihwal Lee
>         Attachments: hadoop-10527.patch
>
>
> After HADOOP-10522, user/group look-up will only try up to 5 times on EINTR.  
> More retries should be allowed just in case.
> Also, when a user/group lookup returns no entries, the wrapper methods are 
> returning EIO, instead of ENOENT.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to