[
https://issues.apache.org/jira/browse/HADOOP-10527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13977128#comment-13977128
]
Colin Patrick McCabe commented on HADOOP-10527:
-----------------------------------------------
Looks better.
{code}
+ for (ret = 0, buf_sz = uinfo->buf_sz; buf_sz < MAX_USER_BUFFER_SIZE;) {
{code}
This means that once {{uinfo->buf_sz}} reaches {{MAX_USER_BUFFER_SIZE}}, we'll
never run the loop again. This doesn't seem like what you intended. How about
a do... while loop?
Also, please remove the comments about errno not being thread-safe.
> Fix incorrect return code and allow more retries on EINTR
> ---------------------------------------------------------
>
> Key: HADOOP-10527
> URL: https://issues.apache.org/jira/browse/HADOOP-10527
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Attachments: hadoop-10527.patch, hadoop-10527.patch
>
>
> After HADOOP-10522, user/group look-up will only try up to 5 times on EINTR.
> More retries should be allowed just in case.
> Also, when a user/group lookup returns no entries, the wrapper methods are
> returning EIO, instead of ENOENT.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
