[
https://issues.apache.org/jira/browse/HADOOP-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980261#comment-13980261
]
Chris Nauroth commented on HADOOP-10521:
----------------------------------------
Hi, Yi. This looks good overall. Here are a few comments:
# Are you planning on implementing recursive getfattr with the -R flag? It
would be easy to implement, because the base class provides all the
functionality for driving the recursion.
# Please replace use of {{StringBuffer}} with {{StringBuilder}}.
# Shall we remove {{ENCODE#getEncode}} if it's unused, or are you anticipating
using this in a later patch?
# The getfattr description of the -n flag contains some redundant text. Also,
"hexidecimal" is misspelled in the encoding description.
# The setfattr description of hte -x flag is missing a newline at the end.
This causes the description of the path argument to be printed on the same line.
# Optional: You might explore using the {{CommandFormat}} helper class to see
if that would simplify argument parsing logic. There are examples of this in
the code for other commands.
> FsShell commands for extended attributes.
> -----------------------------------------
>
> Key: HADOOP-10521
> URL: https://issues.apache.org/jira/browse/HADOOP-10521
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HADOOP-10521.1.patch, HADOOP-10521.2.patch,
> HADOOP-10521.patch
>
>
> “setfattr” and “getfattr” commands are added to FsShell for XAttr, and these
> are the same as in Linux.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
