[
https://issues.apache.org/jira/browse/HADOOP-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980483#comment-13980483
]
Andrew Wang commented on HADOOP-10521:
--------------------------------------
Few more nits in addition to Chris's comments:
* {{respectively\n" +}} needs a period.
* An alternative to CommandFormat is {{StringUtils.popOptionWithArgument}} and
friends, maybe easier. Some usage examples in CacheAdmin.
* Some lines longer than 80 chars
* {{ If the given string}} has two spaces beforehand, consistency.
* When we get the actual implementation in, I'd like to see tests for the
different input and output modes, e.g. text, base64, hex. TestCacheAdminCLI
might serve as a useful reference here, along with
{{src/test/resources/testCacheAdminConf.xml}}.
Thanks Yi.
> FsShell commands for extended attributes.
> -----------------------------------------
>
> Key: HADOOP-10521
> URL: https://issues.apache.org/jira/browse/HADOOP-10521
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs
> Affects Versions: HDFS XAttrs (HDFS-2006)
> Reporter: Yi Liu
> Assignee: Yi Liu
> Attachments: HADOOP-10521.1.patch, HADOOP-10521.2.patch,
> HADOOP-10521.patch
>
>
> “setfattr” and “getfattr” commands are added to FsShell for XAttr, and these
> are the same as in Linux.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
