[
https://issues.apache.org/jira/browse/HADOOP-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994932#comment-13994932
]
Binglin Chang commented on HADOOP-10564:
----------------------------------------
Hi, Colin, thanks for the patch, some comments:
1. it's hard to remember which field needs free(some are stack alloc, some are
heap) which didn't, could you add comments of each field's memory ownership?
2. in patch line: 690
{code}
690 + proxy->call.remote = *remote;
691 + proxy->call.remote = *remote;
{code}
3. reactor.c 71 RB_NFIND may always find nothing, based on what the RB tree
compare method's content(only pointer equal means equal). I am not familiar
with RB_tree's semantic and the header file doesn't provide any document. And
hrpc_conn_usable may be redundant cause RB_NFIND already checks those fields.
> Add username to native RPCv9 client
> -----------------------------------
>
> Key: HADOOP-10564
> URL: https://issues.apache.org/jira/browse/HADOOP-10564
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: native
> Affects Versions: HADOOP-10388
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10564-pnative.002.patch,
> HADOOP-10564-pnative.003.patch, HADOOP-10564.001.patch
>
>
> Add the ability for the native RPCv9 client to set a username when initiating
> a connection.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
