[
https://issues.apache.org/jira/browse/HADOOP-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995461#comment-13995461
]
Colin Patrick McCabe commented on HADOOP-10564:
-----------------------------------------------
Abe said:
bq. In hadoop-native-core/common/user.c seems like it should be ERANGE? It
seems like it's checking an upper boundary.
OK.
Binglin said:
bq. 1. it's hard to remember which field needs free(some are stack alloc, some
are heap) which didn't, could you add comments of each field's memory ownership?
I added comments to {{hrpc_proxy_init}}.
bq. 2. in patch line: 690
Fixed
bq. 3. reactor.c 71 RB_NFIND may always find nothing, based on what the RB tree
compare method's content(only pointer equal means equal). I am not familiar
with RB_tree's semantic and the header file doesn't provide any document. And
hrpc_conn_usable may be redundant cause RB_NFIND already checks those fields.
There is some documentation in {{tree.h}}:
{code}
/* Finds the first node greater than or equal to the search key */ \
attr struct type * \
name##_RB_NFIND(struct name *head, struct type *elm) \
{code}
As the comment says, {{RB_NFIND}} finds the first node greater than or equal to
the search key. This is similar to {{java.util.TreeMap.floorKey}}.
> Add username to native RPCv9 client
> -----------------------------------
>
> Key: HADOOP-10564
> URL: https://issues.apache.org/jira/browse/HADOOP-10564
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: native
> Affects Versions: HADOOP-10388
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10564-pnative.002.patch,
> HADOOP-10564-pnative.003.patch, HADOOP-10564-pnative.004.patch,
> HADOOP-10564.001.patch
>
>
> Add the ability for the native RPCv9 client to set a username when initiating
> a connection.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
