[
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14016746#comment-14016746
]
Charles Lamb commented on HADOOP-10561:
---------------------------------------
Yi,
This looks pretty good. A few more minor nits:
protected static enum FileAttribute{
Please put a space before the {
The indentation of this:
private EnumSet<FileAttribute> preserveStatus =
+ EnumSet.noneOf(FileAttribute.class);
should be 2, not 4.
+ "(topx) (timestamps, ownership, permission, XAttr).\n" +
How about "[topx] (Timestamps, Ownership, Permission, XAttrs).\n"
and ditto here of course:
+ <expected-output>^( |\t)*\(topx\) \(timestamps, ownership,
permission, XAttr\).( )*</expected-output>
> Copy command with preserve option should handle Xattrs
> ------------------------------------------------------
>
> Key: HADOOP-10561
> URL: https://issues.apache.org/jira/browse/HADOOP-10561
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Uma Maheswara Rao G
> Assignee: Yi Liu
> Attachments: HADOOP-10561.1.patch, HADOOP-10561.2.patch,
> HADOOP-10561.patch
>
>
> The design docs for Xattrs stated that we handle preserve options with copy
> commands
> From doc:
> Preserve option of commands like “cp -p” shell command and “distcp -p” should
> work on XAttrs.
> In the case of source fs supports XAttrs but target fs does not support,
> XAttrs will be ignored
> with warning message
--
This message was sent by Atlassian JIRA
(v6.2#6252)
