[ 
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028146#comment-14028146
 ] 

Chris Nauroth commented on HADOOP-10561:
----------------------------------------

I have one more question.  The issue description says this:

bq. In the case of source fs supports XAttrs but target fs does not support, 
XAttrs will be ignored with warning message

It looks like the patch instead causes the command to fail if the target 
doesn't support xattrs.  It calls {{FileSystem#setXAttr}}, and it lets 
exceptions propagate out.  I think this behavior is preferable, especially with 
consideration that xattrs are used in the implementation of encryption zones.  
If the user requested preserving xattrs, then dropping xattrs related to 
encryption could accidentally open access to encrypted data at the target, and 
a log message wouldn't give enough visibility into the problem.

Maybe we just need to update the issue description.

> Copy command with preserve option should handle Xattrs
> ------------------------------------------------------
>
>                 Key: HADOOP-10561
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10561
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>         Attachments: HADOOP-10561.1.patch, HADOOP-10561.2.patch, 
> HADOOP-10561.3.patch, HADOOP-10561.4.patch, HADOOP-10561.patch
>
>
> The design docs for Xattrs stated that we handle preserve options with copy 
> commands
> From doc:
> Preserve option of commands like “cp -p” shell command and “distcp -p” should 
> work on XAttrs. 
> In the case of source fs supports XAttrs but target fs does not support, 
> XAttrs will be ignored 
> with warning message



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to