[
https://issues.apache.org/jira/browse/HADOOP-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038105#comment-14038105
]
Charles Lamb commented on HADOOP-10695:
---------------------------------------
I would think you would want separate params for the connect timeout and read
timeout.
Nits:
private static final String TIMEOUT_ATTR = CONFIG_PREFIX + "timeout"; // secs
private static final int defaultTimeout = 60; // seconds
I'd prefer if the // comments were /* */ comments on the line above. Also,
perhaps rename "defaultTimeout" to DEFAULT_TIMEOUT.
Should there be constants for the 1000 (seconds/ms) conversion factors? I
wouldn't be surprised if there already were some of those in the HADOOP
codebase that you could use, but someone else can comment on that.
> KMSClientProvider should respect a configurable timeout.
> --------------------------------------------------------
>
> Key: HADOOP-10695
> URL: https://issues.apache.org/jira/browse/HADOOP-10695
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Mike Yoder
> Attachments: HADOOP-10695.patch
>
>
> It'd be good if KMSClientProvider used a timeout, so it doesn't hang forever
> if the KMServer is down.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
