[
https://issues.apache.org/jira/browse/HADOOP-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038991#comment-14038991
]
Mike Yoder commented on HADOOP-10695:
-------------------------------------
Thanks for the review! I renamed and used /* */ as per your good suggestions.
I didn't see any constants regarding 1000 but could have missed them - a quick
search turned up 300+ usages of "1000;" in the code. :-) Anyway the conversion
seems straightforward enough.
As for making the read and connect timeouts separately configurable - I pose
this as a philosophical question for the group. On one side (two separate
config knobs) we give the user the benefit of being able to configure the
underlying connection with the interfaces that the connection gives us; on the
other side (one timeout knob) is a desire to remove unneeded complexity from
the configuration.
FWIW, looking through the existing code base I see at least three places where
both the connect and read timeouts are set to the same timeout value.
One final thing - how do I tell jira that I didn't write any new tests and
that's OK?
> KMSClientProvider should respect a configurable timeout.
> --------------------------------------------------------
>
> Key: HADOOP-10695
> URL: https://issues.apache.org/jira/browse/HADOOP-10695
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Mike Yoder
> Attachments: HADOOP-10695.patch
>
>
> It'd be good if KMSClientProvider used a timeout, so it doesn't hang forever
> if the KMServer is down.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
