[
https://issues.apache.org/jira/browse/HADOOP-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14038195#comment-14038195
]
Mike Liddell commented on HADOOP-9559:
--------------------------------------
[~vicaya] I think DefaultMetricsSystem#sourceName is not new code (and it is
used by MetricsSystemImpl). so Nofix.
new patch will be added with small amendments: just adding @VisibleForTesting
to MetricsSourceAdapter#getMBeanName() and MetricsSystemImpl#getSourceAdapter
> When metrics system is restarted MBean names get incorrectly flagged as dupes
> -----------------------------------------------------------------------------
>
> Key: HADOOP-9559
> URL: https://issues.apache.org/jira/browse/HADOOP-9559
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Mostafa Elhemali
> Attachments: HADOOP-9559.2.txt, HADOOP-9559.patch
>
>
> In the Metrics2 system, every source gets registered as an MBean name, which
> gets put into a unique name pool in the singleton DefaultMetricsSystem
> object. The problem is that when the metrics system is shutdown (which
> unregisters the MBeans) this unique name pool is left as is, so if the
> metrics system is started again every attempt to register the same MBean
> names fails (exception is eaten and a warning is logged).
> I think the fix here is to remove the name from the unique name pool if an
> MBean is unregistered, since it's OK at this point to add it again.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
